Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

creating client fails with unable to get 16 bytes for UUID, got 10 #534

Closed
3 tasks done
sb2nov opened this issue Apr 17, 2020 · 4 comments · Fixed by #536 or #539
Closed
3 tasks done

creating client fails with unable to get 16 bytes for UUID, got 10 #534

sb2nov opened this issue Apr 17, 2020 · 4 comments · Fixed by #536 or #539
Labels
bug This issue is a bug.

Comments

@sb2nov
Copy link

sb2nov commented Apr 17, 2020

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug
Creating a new aws client would sometimes fail with unable to get 16 bytes for UUID, got 10 the number of bytes fetched is inconsistent.

Version of AWS SDK for Go?
Example: v0.20.0

  • get SDK version by printing the output of aws.SDKVersion in your code after importing "github.com/aws/aws-sdk-go-v2/aws"

Version of Go (go version)?
1.14.2

To Reproduce (observed behavior)
Creating dynamodb clients again and again would fail with this once in a while.

Expected behavior
No error
@sb2nov
Copy link
Author

sb2nov commented Apr 17, 2020

This doesn't happen in v0.19 so most likely some side effect of pr #487

jasdel added a commit to jasdel/aws-sdk-go-v2 that referenced this issue Apr 21, 2020
@jasdel
Fix SDK's UUID utility to handle partial read
344ada4 
Fixes the SDK's UUID utility to correctly handle partial reads from its
crypto rand source. This error was sometimes causing the SDK's
InvocationID value to fail to be obtained, due to a partial read from
crypto.Rand.

Fix aws#534
@jasdel jasdel mentioned this issue Apr 21, 2020
Merged
@jasdel
Copy link
Contributor

jasdel commented Apr 21, 2020

Thanks for reporting this bug @sb2nov I've posted PR #536 that fixes the SDKs behavior when reading from a crypto source to ensure it gets all the bytes it needs.

@jasdel jasdel added the bug This issue is a bug. label Apr 21, 2020
@sb2nov
Copy link
Author

sb2nov commented Apr 21, 2020

Thanks for the quick fix @jasdel, appreciate the help :)

jasdel added a commit that referenced this issue Apr 21, 2020
@jasdel
internal/sdk: Fix SDK's UUID utility to handle partial read (#536)
66c29ca 
Fixes the SDK's UUID utility to correctly handle partial reads from its
crypto rand source. This error was sometimes causing the SDK's
InvocationID value to fail to be obtained, due to a partial read from
crypto.Rand.

Fix #534
jasdel added a commit that referenced this issue Apr 21, 2020
@jasdel
Release v0.21.0 (2020-04-21)
1d45499 
===

Breaking Change
---
* `aws/endpoints`: Several functions and types have been removed
  * Removes `DecodeModel` and `DecodeModelOptions` from the package ([#509](#509))
  * Remove Region Constants, Partition Constants, and types use for exploring the endpoint data model ([#512](#512))
* `service/s3/s3crypto`: Package and associated encryption/decryption clients have been removed from the SDK ([#511](#511))
* `aws/external`: Removes several export constants and types ([#508](#508))
  * No longer exports AWS environment constants used by the external environment configuration loader
  * `DefaultSharedConfigProfile` is now defined an exported constant
* `aws`: `ErrMissingRegion`, `ErrMissingEndpoint`, `ErrStaticCredentialsEmpty` are now concrete error types ([#510](#510))

Services
---
* Synced the V2 SDK with latest AWS service API definitions.

SDK Features
---
* `aws/signer/v4`: New methods `SignHTTP` and `PresignHTTP` have been added ([#519](#519))
  * `SignHTTP` replaces `Sign`, and usage of `Sign` should be migrated before it's removal at a later date
  * `PresignHTTP` replaces `Presign`, and usage of `Presign` should be migrated before it's removal at a later date
  * `DisableRequestBodyOverwrite` and `UnsignedPayload` are now deprecated options and have no effect on `SignHTTP` or `PresignHTTP`. These options will be removed at a later date.
* `aws/external`: Add Support for setting a default fallback region and resolving region from EC2 IMDS ([#523](#523))
  * `WithDefaultRegion` helper has been added which can be passed to `LoadDefaultAWSConfig`
    * This helper can be used to configure a default fallback region in the event a region fails to be resolved from other sources
  * Support has been added to resolve region using EC2 IMDS when available
    * The IMDS region will be used if region as not found configured in either the shared config or the process environment.
  * Fixes [#244](#244)
  * Fixes [#515](#515)
SDK Enhancements
---
* `service/dynamodb/expression`: Add IsSet helper for ConditionBuilder and KeyConditionBuilder ([#494](#494))
  * Adds a IsSet helper for ConditionBuilder and KeyConditionBuilder to make it easier to determine if the condition builders have any conditions added to them.
  * Implements [#493](#493).
* `internal/ini`: Normalize Section keys to lowercase ([#495](#495))
  * Update's SDK's ini utility to store all keys as lowercase. This brings the SDK inline with the AWS CLI's behavior.

SDK Bugs
---
* `internal/sdk`: Fix SDK's UUID utility to handle partial read ([#536](#536))
  * Fixes the SDK's UUID utility to correctly handle partial reads from its crypto rand source. This error was sometimes causing the SDK's InvocationID value to fail to be obtained, due to a partial read from crypto.Rand.
  * Fix [#534](#534)
* `aws/defaults`: Fix request metadata headers causing signature errors ([#536](#536))
    * Fixes the SDK's adding the request metadata headers in the wrong location within the request handler stack. This created a situation where a request that was retried would sign the new attempt using the old value of the header. The header value would then be changed before sending the request.
    * Fix [#533](#533)
    * Fix [#521](#521)
@jasdel jasdel mentioned this issue Apr 21, 2020
Merged
jasdel added a commit that referenced this issue Apr 22, 2020
@jasdel
Release v0.21.0 (2020-04-21) (#539)
b8a3f09 
Breaking Change
---
* `aws/endpoints`: Several functions and types have been removed
  * Removes `DecodeModel` and `DecodeModelOptions` from the package ([#509](#509))
  * Remove Region Constants, Partition Constants, and types use for exploring the endpoint data model ([#512](#512))
* `service/s3/s3crypto`: Package and associated encryption/decryption clients have been removed from the SDK ([#511](#511))
* `aws/external`: Removes several export constants and types ([#508](#508))
  * No longer exports AWS environment constants used by the external environment configuration loader
  * `DefaultSharedConfigProfile` is now defined an exported constant
* `aws`: `ErrMissingRegion`, `ErrMissingEndpoint`, `ErrStaticCredentialsEmpty` are now concrete error types ([#510](#510))

Services
---
* Synced the V2 SDK with latest AWS service API definitions.

SDK Features
---
* `aws/signer/v4`: New methods `SignHTTP` and `PresignHTTP` have been added ([#519](#519))
  * `SignHTTP` replaces `Sign`, and usage of `Sign` should be migrated before it's removal at a later date
  * `PresignHTTP` replaces `Presign`, and usage of `Presign` should be migrated before it's removal at a later date
  * `DisableRequestBodyOverwrite` and `UnsignedPayload` are now deprecated options and have no effect on `SignHTTP` or `PresignHTTP`. These options will be removed at a later date.
* `aws/external`: Add Support for setting a default fallback region and resolving region from EC2 IMDS ([#523](#523))
  * `WithDefaultRegion` helper has been added which can be passed to `LoadDefaultAWSConfig`
    * This helper can be used to configure a default fallback region in the event a region fails to be resolved from other sources
  * Support has been added to resolve region using EC2 IMDS when available
    * The IMDS region will be used if region as not found configured in either the shared config or the process environment.
  * Fixes [#244](#244)
  * Fixes [#515](#515)

SDK Enhancements
---
* `service/dynamodb/expression`: Add IsSet helper for ConditionBuilder and KeyConditionBuilder ([#494](#494))
  * Adds a IsSet helper for ConditionBuilder and KeyConditionBuilder to make it easier to determine if the condition builders have any conditions added to them.
  * Implements [#493](#493).
* `internal/ini`: Normalize Section keys to lowercase ([#495](#495))
  * Update's SDK's ini utility to store all keys as lowercase. This brings the SDK inline with the AWS CLI's behavior.


SDK Bugs
---
* `internal/sdk`: Fix SDK's UUID utility to handle partial read ([#536](#536))
  * Fixes the SDK's UUID utility to correctly handle partial reads from its crypto rand source. This error was sometimes causing the SDK's InvocationID value to fail to be obtained, due to a partial read from crypto.Rand.
  * Fix [#534](#534)
* `aws/defaults`: Fix request metadata headers causing signature errors ([#536](#536))
    * Fixes the SDK's adding the request metadata headers in the wrong location within the request handler stack. This created a situation where a request that was retried would sign the new attempt using the old value of the header. The header value would then be changed before sending the request.
    * Fix [#533](#533)
    * Fix [#521](#521)
@jasdel
Copy link
Contributor

jasdel commented Apr 22, 2020

We've released this fix as a tagged released, v0.21.0. You should be able to update to pull in these fixes and updates.

meshuga added a commit to meshuga/terraformer that referenced this issue May 1, 2020
@meshuga
code review, fix aws/aws-sdk-go-v2#534, silencing not available AWS s…
0415dbd 
…ervices
@chenrui333 chenrui333 mentioned this issue Dec 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
2 participants
@jasdel @sb2nov