Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions for SDK and codegen CI testing #1261

Merged
merged 1 commit into from
May 17, 2021

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented May 14, 2021

Adds GitHub Actions for Go 1.15, 1.16 SDK unit testing and Java codegen. Go tip is not included yet, relying on to rely on Travis CI for these until added to GitHub Actions.

@jasdel jasdel force-pushed the addGitHubActions branch 2 times, most recently from cac3086 to b0b4b6d Compare May 15, 2021 16:34
@jasdel
Copy link
Contributor Author

jasdel commented May 16, 2021

Looks like test are overall faster than Travis, also codegen java 11 failed on Travis. We should consider dropping all Travis tests except Go tip tests.

@jasdel jasdel force-pushed the addGitHubActions branch 2 times, most recently from 63bd82e to 392857f Compare May 17, 2021 16:59
Adds GitHub Actions for Go 1.15, 1.16 SDK unit testing and Java codegen.
Go tip is not included yet, relying on to rely on Travis CI for these
until added to GitHub Actions.
Comment on lines +28 to +30
- uses: actions/setup-go@v2
with:
go-version: ${{ matrix.go-version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much nicer then what I had to do with Travis CI recently.

# os: [windows-latest]
# experimental: true
env:
EACHMODULE_SKIP: "internal\\repotools\\changes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove this code now, we can do that in a separate PR.

@jasdel jasdel merged commit 4a50e35 into aws:main May 17, 2021
@jasdel jasdel deleted the addGitHubActions branch May 17, 2021 19:03
jrichard8 pushed a commit to jrichard8/aws-sdk-go-v2 that referenced this pull request Feb 14, 2022
Adds GitHub Actions for Go 1.15, 1.16 SDK unit testing and Java codegen.
Go tip is not included yet, relying on to rely on Travis CI for these
until added to GitHub Actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants