S3: REST-XML prototype unmarshaler deligates to Legacy Unmarshaler (GetObject operation) #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
skotambkar
commented
Jan 7, 2020
skotambkar
commented
- PR serves as a first step towards our new unmarshaler design.
- unmarshal.go outlines our unmarshaler type and associated unmarshaling methods that currently delegate to legacy unmarshaler of the SDK.
jasdel
suggested changes
Jan 14, 2020
skotambkar
force-pushed
the
proto/unmarshalS3
branch
from
fcd3346
to
12cf8dc
Compare
jasdel
suggested changes
Jan 20, 2020
skotambkar
force-pushed
the
proto/unmarshalS3
branch
2 times, most recently
from
98e6f7a
to
68ec8bf
Compare
skotambkar
force-pushed
the
feature/GeneratedMarshaling
branch
from
1cd370a
to
875184f
Compare
jasdel
reviewed
Feb 11, 2020
skotambkar
force-pushed
the
proto/unmarshalS3
branch
2 times, most recently
from
6c8641e
to
590df65
Compare
jasdel
force-pushed
the
feature/GeneratedMarshaling
branch
from
875184f
to
2550cb3
Compare
skotambkar
force-pushed
the
proto/unmarshalS3
branch
from
590df65
to
db24dfb
Compare
jasdel
suggested changes
Mar 2, 2020
service/s3/unmarshal.go
Outdated
Comment on lines
74
to
81
| func unmarshalErrorPrototype(r *aws.Request, d *xml.Decoder, startToken xml.Token) error { | ||
| // protoXMLErrorResponse is error response struct for xml errors. | ||
| var respErr = protoXMLErrorResponse{} | ||
|
|
||
| // Delegate to reflection based decoding utils | ||
| if start, ok := startToken.(xml.StartElement); ok { | ||
| err := d.DecodeElement(&respErr, &start) | ||
| if err != nil && err != io.EOF { |
There was a problem hiding this comment.
would be great for this to take a StartElement type instead of Token. The caller should be responsible for getting the first StartElement. This is helpful because the first Token might be something like the XML preamble.
skotambkar
changed the title
service: prototype GetObject op to use unmarshaler type, that delegates to legacy unmarshaler
jasdel
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.