Fix API client generation issues discovered in new model builds #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
For sts client, we see a missing dependency of strconv.
Can you add that in this PR, or can be separate; doesn't have to block this pr.
github.com/aws/aws-sdk-go-v2/service/sts [github.com/aws/aws-sdk-go-v2/service/sts.test]
./deserializers.go:1598:17: undefined: strconv
skotambkar
approved these changes
Sep 3, 2020
|
Looks like also missed transcribe streaming, Will also need to ignore event stream operations for now until supported. |
skmcgrail
pushed a commit
that referenced
this pull request
Sep 24, 2020
Fixes issues with the API client codegen that were discovered in the latest set of models added to the SDK. * Fixes `bytes` package not being imported for document payload serializers. * Fixup IdempotencyToken resolver added in correct scope. If IdempotencyToken was used as a member, not on the top level shape it would cause the resolver to be generated, but the client option was never set. Regenerates API models for operation input/output (de)serialization helper function names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with the API client codegen that were discovered in the latest set of models added to the SDK.
bytespackage not being imported for document payload serializers.Regenerates API models for operation input/output (de)serialization helper function names.