TestRequestUserAgent fails on EC2

[jamie-digital]

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

Latest (1.16.9)

Version of Go (go version)?

go version go1.11.4 darwin/amd64

What issue did you see?

--- FAIL: TestRequestUserAgent (0.00s)
 request_test.go:319: expect "foo/bar aws-sdk-go/1.15.27 (go1.11.4; linux; amd64)" user agent, got "foo/bar aws-sdk-go/1.15.27 (go1.11.4; linux; amd64) exec_env/AWS_ECS_EC2"
FAIL
FAIL github.com/aws/aws-sdk-go/aws/request 8.232s

The problem is that the test assumes that no environment data will be added, so the test fails on EC2 where that fact is added to the User-Agent string.

func TestRequestUserAgent(t *testing.T) {
	s := awstesting.NewClient(&aws.Config{Region: aws.String("us-east-1")})
	//	s.Handlers.Validate.Clear()

	req := s.NewRequest(&request.Operation{Name: "Operation"}, nil, &testData{})
	req.HTTPRequest.Header.Set("User-Agent", "foo/bar")
	if err := req.Build(); err != nil {
		t.Fatalf("expect no error, got %v", err)
	}

	expectUA := fmt.Sprintf("foo/bar %s/%s (%s; %s; %s)",
		aws.SDKName, aws.SDKVersion, runtime.Version(), runtime.GOOS, runtime.GOARCH)
	if e, a := expectUA, req.HTTPRequest.Header.Get("User-Agent"); e != a {
		t.Errorf("expect %q user agent, got %q", e, a)
	}
}

Steps to reproduce

Test the package on an EC2 environment, such as CodeBuild.

[jasdel]

Thanks for reporting this issue @jamie-digital. The test case needs to be updated to work consistently. If you're looking to create a PR we're glad to review it, otherwise we'll schedule some time to fix this issue.

[jamie-digital]

Hi @jasdel. I'm afraid I don't have the resources to submit a PR, but while I was triaging the issue I found that the extra environment variable data is added here, so it might just be a case of copying that functionality into the test for the expected value.