Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for API waiters #59

Closed
stripecodahale opened this issue Jan 8, 2015 · 6 comments
Closed

Add support for API waiters #59

stripecodahale opened this issue Jan 8, 2015 · 6 comments
Labels
feature-request A feature should be added or improved. help wanted We are asking the community to submit a PR to resolve this issue.

Comments

@stripecodahale
Copy link
Contributor

e.g. https://github.com/boto/botocore/blob/develop/botocore/data/aws/ec2/2014-10-01.waiters.json

@stripecodahale stripecodahale added enhancement help wanted We are asking the community to submit a PR to resolve this issue. labels Jan 8, 2015
@lsegal
Copy link
Contributor

lsegal commented Mar 28, 2015

There is experimental support for waiters in the waiters branch. Sample waiter code:

package main

import (
    "fmt"

    "github.com/awslabs/aws-sdk-go/aws"
    "github.com/awslabs/aws-sdk-go/service/ec2"
)

func main() {
    svc := ec2.New(nil)
    fmt.Println("Waiting on instance...")
    svc.WaitUntilInstanceRunning(&ec2.DescribeInstancesInput{
        InstanceIDs: []*string{aws.String("i-12345678f")},
    })
    fmt.Println("RUNNING!")
}

@lsegal lsegal added help wanted We are asking the community to submit a PR to resolve this issue. investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed help wanted We are asking the community to submit a PR to resolve this issue. labels Mar 28, 2015
@jszwedko
Copy link

Awesome, that is looking good @lsegal.

One thing I like about some of the other AWS SDKs, e.g. Ruby, is that it provides a hook into the polling process.

@georgyo
Copy link

georgyo commented Sep 28, 2015

Has any progress been made on this, is there a plan to merge this, and what else needs to be done for it?

The last commits to the waiters branch were on Mar 28.

@jasdel
Copy link
Contributor

jasdel commented Oct 13, 2015

Hi @georgyo I updated the waiters branch. Syncing it with the latest version of the SDK. We still are working on finishing up the Waiter support. Specifically we need to improve the JSON path searching waiters use to know what fields of a service response signify the status the waiter is waiting on.

@jszwedko
Copy link

👏 thank you @jasdel !

@jasdel jasdel removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Nov 10, 2015
@jasdel
Copy link
Contributor

jasdel commented Nov 10, 2015

Waiters have now been added to the SDK. Check them out in the latest release v0.10.3. Let us know if you have any questions or feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. help wanted We are asking the community to submit a PR to resolve this issue.
Projects
None yet
Development

No branches or pull requests

6 participants