-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for API waiters #59
Comments
There is experimental support for waiters in the waiters branch. Sample waiter code: package main
import (
"fmt"
"github.com/awslabs/aws-sdk-go/aws"
"github.com/awslabs/aws-sdk-go/service/ec2"
)
func main() {
svc := ec2.New(nil)
fmt.Println("Waiting on instance...")
svc.WaitUntilInstanceRunning(&ec2.DescribeInstancesInput{
InstanceIDs: []*string{aws.String("i-12345678f")},
})
fmt.Println("RUNNING!")
} |
Awesome, that is looking good @lsegal. One thing I like about some of the other AWS SDKs, e.g. Ruby, is that it provides a hook into the polling process. |
Has any progress been made on this, is there a plan to merge this, and what else needs to be done for it? The last commits to the waiters branch were on Mar 28. |
Hi @georgyo I updated the waiters branch. Syncing it with the latest version of the SDK. We still are working on finishing up the Waiter support. Specifically we need to improve the JSON path searching waiters use to know what fields of a service response signify the status the waiter is waiting on. |
👏 thank you @jasdel ! |
Waiters have now been added to the SDK. Check them out in the latest release v0.10.3. Let us know if you have any questions or feedback. |
Updates readme with CodeBuild build status. http://docs.aws.amazon.com/codebuild/latest/userguide/sample-build-badges.html
e.g. https://github.com/boto/botocore/blob/develop/botocore/data/aws/ec2/2014-10-01.waiters.json
The text was updated successfully, but these errors were encountered: