Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws: Update Context to be an alias of context.Context for Go 1.9 #2412

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

jasdel
Copy link
Contributor

@jasdel jasdel commented Jan 17, 2019

Updates aws.Context interface to be an alias of the standard libraries context.Context type instead of redefining the interface. This will allow IDEs and utilities to interpret the aws.Context as the exactly same type as the standard libraries context.Context.

Updates aws.Context interface to be an alias of the standard libraries
context.Context type instead of redefining the interface. This will
allow IDEs and utilities to interpret the aws.Context as the exactly
same type as the standard libraries context.Context.
@jasdel jasdel self-assigned this Jan 17, 2019
@jasdel
Copy link
Contributor Author

jasdel commented Jan 21, 2019

Pulling this change in to make the SDK's usage of aws.Context with the standardlibrarie's context.Context. Since the SDK doesn't need its own context type, using Go 1.9's type alias provides the correct definition.

@jasdel jasdel merged commit bd8be1f into aws:master Jan 22, 2019
@jasdel jasdel deleted the enc/TypeAliasContext branch January 22, 2019 19:31
jasdel added a commit that referenced this pull request Jan 22, 2019
Adds PR #2412  to pending change log.
@aws-sdk-go-automation aws-sdk-go-automation mentioned this pull request Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant