Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/s3/s3manager: Uploader should initialize pool size after dete… #3030

Merged
merged 1 commit into from
Dec 23, 2019
Merged

service/s3/s3manager: Uploader should initialize pool size after dete… #3030

merged 1 commit into from
Dec 23, 2019

Conversation

skmcgrail
Copy link
Member

Small change to initialize the buffer pool size after the optimal part size has been calculated.

@skmcgrail skmcgrail added the needs-review This issue or pull request needs review from a core team member. label Dec 18, 2019
@skmcgrail skmcgrail merged commit bf26d57 into aws:master Dec 23, 2019
@skmcgrail skmcgrail deleted the s3manager/upload branch December 23, 2019 18:50
@skmcgrail skmcgrail mentioned this pull request Mar 10, 2020
Merged
skotambkar pushed a commit to skotambkar/aws-sdk-go that referenced this pull request May 20, 2021
@skmcgrail
service/s3/s3manager: Port Improvements from V1 SDK (aws#499)
2b617db 
* Uploader should initialize pool size after determining optimized size. (aws#3030)
* Fix resource leak on failed CreateMultipartUpload calls (aws#3069)
* Fix resource leak on UploadPart failures (aws#3144)
* Improve memory allocations by replacing sync.Pool (aws#3183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

@skotambkar skotambkar skotambkar approved these changes

Assignees
No one assigned
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skmcgrail @jasdel @skotambkar