Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/s3/s3manager: Fix resource leak on UploadPart failures #3144

Merged
merged 2 commits into from Mar 4, 2020

Conversation

skmcgrail
Copy link
Member

Fixes a resource leak if an UploadPart request failed, which could cause other routines to not call their cleanup function.

@skmcgrail skmcgrail merged commit 68d5b4f into aws:master Mar 4, 2020
aws-sdk-go-automation pushed a commit that referenced this pull request Mar 4, 2020
===

### Service Client Updates
* `service/pinpoint`: Updates service API and documentation
  * This release of the Amazon Pinpoint API introduces support for integrating recommender models with email, push notification, and SMS message templates. You can now use these types of templates to connect to recommender models and add personalized recommendations to messages that you send from campaigns and journeys.

### SDK Bugs
* `service/s3/s3manager`: Fix resource leak on UploadPart failures ([#3144](#3144))
aws-sdk-go-automation added a commit that referenced this pull request Mar 4, 2020
Release v1.29.17 (2020-03-04)
===

### Service Client Updates
* `service/pinpoint`: Updates service API and documentation
  * This release of the Amazon Pinpoint API introduces support for integrating recommender models with email, push notification, and SMS message templates. You can now use these types of templates to connect to recommender models and add personalized recommendations to messages that you send from campaigns and journeys.

### SDK Bugs
* `service/s3/s3manager`: Fix resource leak on UploadPart failures ([#3144](#3144))
skotambkar pushed a commit to skotambkar/aws-sdk-go that referenced this pull request May 20, 2021
* Uploader should initialize pool size after determining optimized size. (aws#3030)
* Fix resource leak on failed CreateMultipartUpload calls (aws#3069)
* Fix resource leak on UploadPart failures (aws#3144)
* Improve memory allocations by replacing sync.Pool (aws#3183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants