Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generated SDK errors to use pointer receivers #3207

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Fix generated SDK errors to use pointer receivers #3207

merged 3 commits into from
Mar 30, 2020

Commits on Mar 27, 2020

  1. codegen: Fix SDK errors to use pointer receivers 

    Fixes the generated SDK API errors to use pointer function receivers
instead of value. This fixes potential confusion writing code and not
casting to the correct type. The SDK will always return the API error as
a pointer, not value.

Code that did type assertions from the operation's returned error to the
value type would never be satisfied. Leading to errors being missed.
Changing the function receiver to a pointer prevents this error.
Highlighting it in code bases.
    @jasdel
    jasdel committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    0b3db71 View commit details
    Browse the repository at this point in the history

  2. regenerate API

    @jasdel
    jasdel committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    1901f93 View commit details
    Browse the repository at this point in the history

  3. add changelog

    @jasdel
    jasdel committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    0bd6f5c View commit details
    Browse the repository at this point in the history