private/protocol: Fix protocol unit test for Go 1.16. #3790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the SDK's handling of XML protocol tests to correctly compare two XML document strings without mangling the XML namespace. Fixes aws#3731
jasdel
force-pushed
the
fixup/ProtocoTestGo1.16
branch
from
33e4909
to
653f2c2
Compare
skotambkar
suggested changes
Feb 19, 2021
skotambkar
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the SDK's handling of XML protocol tests to correctly compare two
XML document strings without mangling the XML namespace.
Fixes #3731
Fixes unit and vet for Go 1.16