Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EC2 Presigned URL customization #4808

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

syall
Copy link
Contributor

@syall syall commented Apr 19, 2023

For changes to files under the /model/ folder, and manual edits to autogenerated code (e.g. /service/s3/api.go) please create an Issue instead of a PR for those type of changes.

N/A.


If there is an existing bug or feature this PR is answers please reference it here.

N/A.


Description:

In some cases, the Presigned URL was NOT being sent when calling EC2 CopySnapshot.

This PR fixes the customization responsible for generating the Presigned URL.

Testing:

  1. CI/CD
  2. New unit tests for the customization cases

@syall syall force-pushed the ec2-presigned-url-fix branch 2 times, most recently from 12be017 to 2edaeab Compare April 19, 2023 21:54
In some cases, the Presigned URL was NOT being sent when calling EC2 CopySnapshot.

This PR fixes the customization responsible for generating the Presigned URL.
@syall syall changed the title EC2 Presigned URL Fix Fix EC2 Presigned URL customization Apr 19, 2023
@syall syall marked this pull request as ready for review April 19, 2023 23:58
@syall syall merged commit 42260bb into aws:main Apr 20, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants