Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the cognito timestamp bug. #85

Closed
wants to merge 1 commit into from

Conversation

jvilhuber
Copy link

Adding a missing timestamp definition to the json file, then ran a regen (make in the root)

@lsegal
Copy link
Contributor

lsegal commented Feb 4, 2015

Thanks for the patch! Unfortunately changing the model will not work because the bug will be re-introduced when we update the models. The model itself is correct here, the problem is in the generator, which should be trying to parse unix timestamps in json, since that's the protocol contract. I have a fix for this coming.

@lsegal
Copy link
Contributor

lsegal commented Feb 4, 2015

Note that in the future development happens in the develop branch, we make few changes in master and aren't accepting PRs to master currently (except for serious issues).

@lsegal lsegal closed this in 836c0f7 Feb 4, 2015
@jvilhuber
Copy link
Author

Good to know. Thanks.
Jan.
On Feb 3, 2015 7:15 PM, "Loren Segal" notifications@github.com wrote:

Note that in the future development happens in the develop branch, we make
few changes in master and aren't accepting PRs to master currently.


Reply to this email directly or view it on GitHub
#85 (comment).

skotambkar pushed a commit to skotambkar/aws-sdk-go that referenced this pull request May 20, 2021
Updates the SDK's examples and documentation to use the v2 configuration pattern.

Fix aws#85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants