Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 java sdk, advancedconfiguration has no effect. #130

Closed
gpj1 opened this issue Aug 28, 2017 · 7 comments
Closed

s3 java sdk, advancedconfiguration has no effect. #130

gpj1 opened this issue Aug 28, 2017 · 7 comments
Labels
bug This issue is a bug.

Comments

@gpj1
Copy link

gpj1 commented Aug 28, 2017

I'm using aws java s3 sdk 2.0.0-preview-2 and building s3client like below

S3Client.builder().credentialsProvider(newStaticCredentialsProviderWithBasicCredentials("xxxx", "yyyy")) .advancedConfiguration(S3AdvancedConfiguration.builder().accelerateModeEnabled(true).pathStyleAccessEnabled(true).build()).endpointOverride(new URI("https://mys3compatible.storage:8082")) .build();

But, what I observed while using such s3 client is, the advanced configuration is not taking any effect at all.
When I debugged, I found that, software.amazon.awssdk.client.ClientHandlerImpl#execute(ClientExecutionParams<InputT, OutputT> executionParams) is losing the advanced configuration while building SdkHttpFullRequest

This is causing a blocker for one of our implementation and I'm thinking to switch back to 1.x version of sdk. Could some please guide me?

@shorea
Copy link
Contributor

shorea commented Aug 28, 2017

Taking a look, must be a regression.

@shorea
Copy link
Contributor

shorea commented Aug 28, 2017

Identified the bug, discussing a fix with the team.

@shorea shorea added the bug This issue is a bug. label Sep 5, 2017
@shorea
Copy link
Contributor

shorea commented Sep 5, 2017

Just a quick update, very nearly have this done, just finishing up some tests. Should have this out by tomorrow.

@gpj1
Copy link
Author

gpj1 commented Sep 6, 2017

Thanks for the update @shorea

@shorea
Copy link
Contributor

shorea commented Sep 6, 2017

Got a PR out for this, #142

@shorea
Copy link
Contributor

shorea commented Sep 19, 2017

This has been released in 2.0.0-preview-4

@shorea shorea closed this as completed Sep 19, 2017
@gpj1
Copy link
Author

gpj1 commented Sep 20, 2017

Great work.. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants