Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy configurations for different SDK http clients doesn't have feature parity. #2321

Closed
kra3 opened this issue Mar 9, 2021 · 5 comments
Closed

Proxy configurations for different SDK http clients doesn't have feature parity. #2321

kra3 opened this issue Mar 9, 2021 · 5 comments
Assignees
@erin889
Labels
feature-request A feature should be added or improved. hacktoberfest We encourage contributions to this issue for Hacktoberfest.

Comments

@kra3
Copy link

kra3 commented Mar 9, 2021

Netty and Amazon CRT Http client's proxy configurations are not aware of system proxy settings. Such as those passed in via JDK properties (eg: http.proxyHost, http.proxyPort). However Apache proxy configuration is aware of those properties.

Also, there are other issues to make ProxyConfigurations to feature parity with older aws-sdk-java's Proxy configuration (eg: #1793)
@kra3 kra3 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 9, 2021
@debora-ito
Copy link
Member

Thank you for reaching out @kra3, this is a reasonable feature request.

@debora-ito debora-ito removed the needs-triage This issue or PR still needs to be triaged. label Mar 9, 2021
@debora-ito debora-ito added the hacktoberfest We encourage contributions to this issue for Hacktoberfest. label Oct 1, 2021
@erin889
Copy link
Contributor

erin889 commented Oct 14, 2021

@debora-ito Since it's tagged with hacktoberfest, do you mind I jump in and contribute to it?

@debora-ito
Copy link
Member

@erin889 go for it! And thank you for your interest!

@erin889 erin889 mentioned this issue Oct 15, 2021
Merged
13 tasks
@Bennett-Lynch
Copy link
Contributor

Resolved via #2771.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@ssalonen ssalonen mentioned this issue Dec 31, 2021
Merged
aws-sdk-java-automation added a commit that referenced this issue Jan 10, 2023
@aws-sdk-java-automation
Merge pull request #2321 from aws/staging/c5afe014-be8a-4aa0-94e0-c73…
11069c8 
…0a9201a4c

Pull request: release <- staging/c5afe014-be8a-4aa0-94e0-c730a9201a4c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erin889 erin889

Labels
feature-request A feature should be added or improved. hacktoberfest We encourage contributions to this issue for Hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kra3 @debora-ito @Bennett-Lynch @erin889