Implement pause/resume for downloadFile in S3 transfer manager #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e overwriting existing files (#3125) * Expose an option to overwrite an existing file in FileAsyncResponseTransformer * Add changelog entries and make TM use CREATE_OR_REPLACE_EXISTING write option by default * Address feedback * Update and address feedback
…adFile operation (#3094) * Part 1: Implement pause for downloadFile operation * Address feedback * Refactor the logic * Address feedback * Fix merging issue
…le (#3157) * Implement resumeDownloadFile * Move test code around * Address feedback * Fix flaky test * fix flaky integ test
zoewangg
force-pushed
the
zoewang/tm-download-pause-resume
branch
6 times, most recently
from
70ba9cf
to
7a63469
Compare
zoewangg
force-pushed
the
zoewang/tm-download-pause-resume
branch
from
7a63469
to
99c14f7
Compare
cenedhryn
reviewed
Apr 26, 2022
core/sdk-core/src/main/java/software/amazon/awssdk/core/FileTransformerConfiguration.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/FileTransformerConfiguration.java
Outdated
Show resolved
Hide resolved
core/sdk-core/src/main/java/software/amazon/awssdk/core/FileTransformerConfiguration.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @ParameterizedTest | ||
| @MethodSource("configurations") |
cenedhryn
approved these changes
Apr 26, 2022
|
Kudos, SonarCloud Quality Gate passed! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Implement pause/resume for downloadFile in S3 transfer manager
Modifications
Merging the feature branch to mainline. All implementation related changes have been reviewed in separate PRs(#3125, #3094, #3157).
Testing
Added unit tests and integ tests.
Running the tests now.Integ tests passedTypes of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License