-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backward-compatible setMultipartCopyThreshold #637
Conversation
…k with Hadoop 2.7
it says the compilation failure is "javac: invalid target release: 1.7" when building with "openjdk6", well obviously... |
Hey Romi, thanks very much for the PR! Makes sense to introduce this in order to unblock users on existing versions of Hadoop. That said I would probably have a preference towards marking the method as deprecated so that we can eventually plan to get away from it in a future major version bump of the SDK (and once several versions of Hadoop containing hitting the new method have been proliferated throughout the user base). Aside from that my only other question is if you can please confirm you are submitting this code under the Apache 2.0 license? |
…d method for Hadoop 2.7
hi @breedloj |
Great, thanks for the update! I've staged this change so that it'll go out as part of our next scheduled release this week. |
thanks! |
Our release process happens internally and out of band of GitHub. Hence we must pull in new PRs locally to stage them for our release, at which point the changes will make their way out to the public SDK artifacts. We tentatively have a release scheduled for today which this change should be a part of. I will definitely let you know once it has been released. |
Just wanted to give you an update: our release process is done and the fix is now live. Thanks again! |
hi @breedloj can you please merge this? |
just for reference, he's the PR that started it all |
Hey Romi, At this point since your original fix went out we will be unable to remove that method as users may already be using it and we cannot make breaking changes until we have a major version bump. Can you create a new PR with the updated fix on top of the current codebase? Thanks. |
Hi, Sure, I'll make a new PR from the new code base. |
Yeah, I spoke with the team about this as well and we believe it'd be safe to remove the erroneous overload so I'd go ahead and do that in the new PR. |
created a new PR |
to allow S3A to work with Hadoop 2.7
instead of waiting for Hadoop 2.8
as described here
https://issues.apache.org/jira/browse/HADOOP-12420