Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump prettier to v2 #1079

Closed
wants to merge 8 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 3, 2020

Issue #, if available:

Description of changes:

  • bumps prettier to v2
  • retains default prettier config from v1 in private package @aws-sdk/prettier-config

Manually restored following folders, as it contains files which are not prettified (to be done separately):

  • codegen/
  • packages/smithy-client/
  • protocol_tests/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@codecov-io
Copy link

codecov-io commented Apr 6, 2020

Codecov Report

Merging #1079 into master will decrease coverage by 12.67%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1079       +/-   ##
===========================================
- Coverage   91.49%   78.81%   -12.68%     
===========================================
  Files         146      279      +133     
  Lines        2868    11594     +8726     
  Branches      511     2401     +1890     
===========================================
+ Hits         2624     9138     +6514     
- Misses        244     2456     +2212     
Impacted Files Coverage Δ
packages/hash-stream-node/src/index.ts 90.00% <0.00%> (ø)
...sts/aws-query/commands/SimpleInputParamsCommand.ts 88.23% <0.00%> (ø)
.../HttpRequestWithLabelsAndTimestampFormatCommand.ts 88.23% <0.00%> (ø)
...ws-query/commands/IgnoresWrappingXmlNameCommand.ts 100.00% <0.00%> (ø)
...tests/aws-restxml/commands/XmlNamespacesCommand.ts 100.00% <0.00%> (ø)
...s/aws-restjson/commands/NoInputAndOutputCommand.ts 100.00% <0.00%> (ø)
.../commands/HttpPayloadTraitsWithMediaTypeCommand.ts 100.00% <0.00%> (ø)
...-restxml/commands/XmlAttributesOnPayloadCommand.ts 100.00% <0.00%> (ø)
...l_tests/aws-ec2/commands/QueryTimestampsCommand.ts 88.23% <0.00%> (ø)
...s-restxml/commands/HttpRequestWithLabelsCommand.ts 88.23% <0.00%> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77386f6...dbb74e4. Read the comment docs.

@aws-sdk-js-automation

This comment has been minimized.

@trivikr trivikr force-pushed the prettier-config branch 2 times, most recently from 397db1d to 20c83e3 Compare April 6, 2020 05:17
@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: dbb74e4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member Author

trivikr commented Apr 6, 2020

Superseded by simplified PR #1083

@trivikr trivikr closed this Apr 6, 2020
@lock
Copy link

lock bot commented Apr 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
@trivikr trivikr deleted the prettier-config branch June 16, 2020 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants