Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump prettier to v2 with .prettierrc #1083

Merged
merged 7 commits into from Apr 8, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 6, 2020

Issue #, if available:

Description of changes:

  • bumps prettier to v2 in root package.json
  • retains default prettier config from v1 in .prettierrc

Manually restored following folders, as it contains files which are not prettified (to be done separately):

  • packages/smithy-client/
  • protocol_tests/

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@trivikr
Copy link
Member Author

trivikr commented Apr 6, 2020

Decision on 04/06: we'll push prettier v2 PR after the existing PRs are pushed:

@codecov-io

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 34d4b56
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⛴

@trivikr trivikr merged commit 4bc605b into aws:master Apr 8, 2020
@trivikr trivikr deleted the prettier-2 branch April 8, 2020 23:48
@lock
Copy link

lock bot commented Apr 17, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants