-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support bi-directional eventstream over H2 #1082
feat: support bi-directional eventstream over H2 #1082
Conversation
This comment has been minimized.
This comment has been minimized.
84cb0d4
to
fdb88f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
+ Coverage 73.33% 73.36% +0.02%
==========================================
Files 285 286 +1
Lines 12399 12412 +13
Branches 2892 2899 +7
==========================================
+ Hits 9093 9106 +13
Misses 3306 3306
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
...pescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsRestXml.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/software/amazon/smithy/aws/typescript/codegen/RestJsonProtocolGenerator.java
Outdated
Show resolved
Hide resolved
...main/java/software/amazon/smithy/aws/typescript/codegen/AddEventStreamSigningDependency.java
Outdated
Show resolved
Hide resolved
...main/java/software/amazon/smithy/aws/typescript/codegen/AddEventStreamSigningDependency.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
3e17e70
to
02f600d
Compare
This comment has been minimized.
This comment has been minimized.
02f600d
to
7de6a68
Compare
This comment has been minimized.
This comment has been minimized.
This PR needs to be revised because of the new design. |
This comment has been minimized.
This comment has been minimized.
3f5bc86
to
084d405
Compare
This comment has been minimized.
This comment has been minimized.
084d405
to
e271da9
Compare
This comment has been minimized.
This comment has been minimized.
e271da9
to
94e79c4
Compare
This comment has been minimized.
This comment has been minimized.
94e79c4
to
5ddc871
Compare
This comment has been minimized.
This comment has been minimized.
5ddc871
to
7f86b04
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d0613df
to
eaddfd0
Compare
This comment has been minimized.
This comment has been minimized.
…lazy stream pumping
8e9bbc0
to
080efeb
Compare
Codecov Report
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
...cript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsDependency.java
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
6620c4c
to
5e49dcc
Compare
This comment has been minimized.
This comment has been minimized.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear from Java side
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
This PR is depend on #1081
AddHttp2Dependency.java
to add Http/2 request handler to service: TranscribeStreaming and Kinesis. Currently only NodeJs requires special request handler for Http/2.AddEventStreamHandlingDependency.java
to support signing event stream in requests with SigV4 streaming speceventstream-handler-node
andmiddleware-eventstream
for JS implementation of singing eventstream requestsThis PR is ready to be reviewed but needs to be merged together with WebSocket support.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.