fix: prettierignore only aws-models #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
approved these changes
Apr 27, 2020
|
Verified that generated clients are prettified: $ yarn generate-clients -g codegen/sdk-codegen/aws-models/iam.2010-05-08.json
...
$ git status
On branch prettier-ignore-only-models
Your branch is up to date with 'origin/prettier-ignore-only-models'.
nothing to commit, working tree clean |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #1115
Description of changes:
codegen/*was added to.prettierignorein chore(deps-dev): bump prettier to v2 with .prettierrc #1083 as the checked-in code from codegen folder should not be prettified.codegen/sdk-codegen/build/smithyprojections/sdk-codegenfolderBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.