Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set workspace TypeScript version in VSCode settings #1461

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 25, 2020

Issue #, if available:
N/A

Description of changes:
Set workspace TypeScript version in VSCode settings so that VSCode uses workspace version all the time:

Documentation: https://code.visualstudio.com/docs/typescript/typescript-compiling#_using-newer-typescript-versions

Screenshots:

Before

code

During (one-time)

selection

After

workspace

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alexforsyth
Copy link
Contributor

Why is the build failing?

@trivikr
Copy link
Member Author

trivikr commented Aug 25, 2020

Why is the build failing?

RangeError: Maximum call stack size exceeded discussed in #1460

Updating VSCode settings won't fail the CI

@trivikr trivikr merged commit 2c27c55 into aws:master Aug 25, 2020
@trivikr trivikr deleted the use-workspace-ts-version branch August 25, 2020 19:51
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants