Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(middleware-bucket-endpoint): support Outposts buckets #1550

Merged
merged 3 commits into from Oct 6, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Description of changes:
This change implements the data plane for S3 Outposts. Now bucketHostname also supports generating outpost endpoint if supplied with an Outpost ARN. It also export some internal util functions that would be useful when validating the other ARN-based features.(e.g. Outposts control plane)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #1550 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1550      +/-   ##
==========================================
+ Coverage   79.84%   80.00%   +0.15%     
==========================================
  Files         304      306       +2     
  Lines       11753    11847      +94     
  Branches     2511     2540      +29     
==========================================
+ Hits         9384     9478      +94     
  Misses       2369     2369              
Impacted Files Coverage Δ
...dleware-bucket-endpoint/src/bucketHostnameUtils.ts 96.47% <0.00%> (-1.87%) ⬇️
packages/middleware-host-header/src/index.ts 80.00% <0.00%> (ø)
packages/middleware-bucket-endpoint/src/index.ts 100.00% <0.00%> (ø)
packages/util-dynamodb/src/convertToNative.ts 100.00% <0.00%> (ø)
packages/util-dynamodb/src/unmarshall.ts 100.00% <0.00%> (ø)
...re-bucket-endpoint/src/bucketEndpointMiddleware.ts 91.89% <0.00%> (+0.22%) ⬆️
...s/middleware-bucket-endpoint/src/bucketHostname.ts 100.00% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76c0068...5f73604. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit c7915d2 into aws:master Oct 6, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants