Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protocol_tests): update protocol_tests with smithy-1.11.x #2644

Merged
merged 2 commits into from Aug 5, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 5, 2021

Issue

Refs: #2643

Description

Update protocol_tests based on smithy-1.11.x

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@27dbd8e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2644   +/-   ##
=======================================
  Coverage        ?   60.61%           
=======================================
  Files           ?      516           
  Lines           ?    27749           
  Branches        ?     6817           
=======================================
  Hits            ?    16820           
  Misses          ?    10929           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27dbd8e...6f092b2. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Aug 5, 2021

CI failures:

Details
Summary of all failing tests
--
324 | FAIL protocol_tests/aws-restxml/tests/functional/restxml.spec.ts (24.898 s)
325 | ● SimpleScalarPropertiesPureWhiteSpace:Response
326 |  
327 | expect(received).toBe(expected) // Object.is equality
328 |  
329 | Expected: true
330 | Received: false
331 |  
332 | 4242 \|   Object.keys(paramsToValidate).forEach((param) => {
333 | 4243 \|     expect(r[param]).toBeDefined();
334 | > 4244 \|     expect(equivalentContents(r[param], paramsToValidate[param])).toBe(true);
335 | \|                                                                   ^
336 | 4245 \|   });
337 | 4246 \| });
338 | 4247 \|
339 |  
340 | at Object.keys.forEach (tests/functional/restxml.spec.ts:4244:67)
341 | at Array.forEach (<anonymous>)
342 | at Object.<anonymous>.it (tests/functional/restxml.spec.ts:4242:33)
343 |  
344 | FAIL protocol_tests/aws-restjson/tests/functional/restjson1.spec.ts (26.65 s)
345 | ● RestJsonHttpChecksumRequired:Request
346 |  
347 | expect(received).toBeDefined()
348 |  
349 | Received: undefined
350 |  
351 | 1918 \|     expect(r.path).toBe("/HttpChecksumRequired");
352 | 1919 \|
353 | > 1920 \|     expect(r.headers["content-md5"]).toBeDefined();
354 | \|                                      ^
355 | 1921 \|     expect(r.headers["content-md5"]).toBe("iB0/3YSo7maijL0IGOgA9g==");
356 | 1922 \|     expect(r.headers["content-type"]).toBeDefined();
357 | 1923 \|     expect(r.headers["content-type"]).toBe("application/json");
358 |  
359 | at Object.<anonymous>.it (tests/functional/restjson1.spec.ts:1920:38)

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 6f092b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 6c33a77 into aws:main Aug 5, 2021
@trivikr trivikr deleted the update-protocol-tests branch August 5, 2021 18:36
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants