Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codegen): skip scalar pure whitespace protocol test #2646

Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 5, 2021

Issue

Refs: #2644 (comment)

Description

Skips the following failing test:

324 | FAIL protocol_tests/aws-restxml/tests/functional/restxml.spec.ts (24.898 s)
325 | ● SimpleScalarPropertiesPureWhiteSpace:Response
326 |  
327 | expect(received).toBe(expected) // Object.is equality
328 |  
329 | Expected: true
330 | Received: false
331 |  
332 | 4242 \|   Object.keys(paramsToValidate).forEach((param) => {
333 | 4243 \|     expect(r[param]).toBeDefined();
334 | > 4244 \|     expect(equivalentContents(r[param], paramsToValidate[param])).toBe(true);
335 | \|                                                                   ^
336 | 4245 \|   });
337 | 4246 \| });
338 | 4247 \|
339 |  
340 | at Object.keys.forEach (tests/functional/restxml.spec.ts:4244:67)
341 | at Array.forEach (<anonymous>)
342 | at Object.<anonymous>.it (tests/functional/restxml.spec.ts:4242:33)

We would follow-up with smithy to check if whitespace only values should be trimmed.

Testing

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: b7beb29
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr changed the title chore(codegen): skip scalar properties pure whitespace protocol test chore(codegen): skip scalar pure whitespace protocol test Aug 5, 2021
@trivikr trivikr merged commit 27dbd8e into aws:main Aug 5, 2021
@trivikr trivikr deleted the skip-SimpleScalarPropertiesPureWhiteSpace-test branch August 5, 2021 18:14
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants