Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(config-resolver): refactor EndpointsConfig into multiple files #2705

Merged
merged 9 commits into from
Aug 25, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 25, 2021

Issue

Follows folder organization done in #2701

Description

Breaks EndpointsConfig to components in separate files with unit tests for each.

Testing

Integration tests

$ yarn test:integration-legacy
yarn run v1.22.11
$ cucumber-js --fail-fast
...............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

150 scenarios (150 passed)
523 steps (523 passed)
1m34.977s
Done in 98.53s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@4f02b78). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2705   +/-   ##
=======================================
  Coverage        ?   60.84%           
=======================================
  Files           ?      537           
  Lines           ?    27915           
  Branches        ?     6851           
=======================================
  Hits            ?    16985           
  Misses          ?    10930           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f02b78...2fe6af8. Read the comment docs.

@trivikr trivikr changed the title chore(config-resolver): make EndpointsConfig modular chore(config-resolver): refactor EndpointsConfig into multiple files Aug 25, 2021
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants