Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-resolver): add options for utility functions #2712

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 25, 2021

Issue

Follow-up to #2705

Description

Adds options for utility functions, so that they receive only the required input.
This is done for future changes where resolveCustomEndpointsConfig can be extended from resolveEndpointsConfig

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@88de69b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2712   +/-   ##
=======================================
  Coverage        ?   61.30%           
=======================================
  Files           ?      537           
  Lines           ?    27444           
  Branches        ?     6699           
=======================================
  Hits            ?    16825           
  Misses          ?    10619           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88de69b...20f522e. Read the comment docs.

@trivikr trivikr merged commit 56ab50e into aws:main Aug 26, 2021
@trivikr trivikr deleted the endpointsConfig-fix branch August 26, 2021 16:49
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants