-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(config-resolver): reuse code in CustomEndpointsConfig #2720
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2720 +/- ##
=======================================
Coverage ? 61.29%
=======================================
Files ? 537
Lines ? 27436
Branches ? 6697
=======================================
Hits ? 16817
Misses ? 10619
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nicer with this refactoring. 1 comment
packages/config-resolver/src/endpointsConfig/resolveCustomEndpointsConfig.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: a typo
packages/config-resolver/src/endpointsConfig/resolveCustomEndpointsConfig.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jaykumar Gosar <5666661+gosar@users.noreply.github.com>
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Follow-up to #2712
Description
Simplify CustomEndpointsConfig by extending types and utility files.
Testing
CI
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.