-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scripts): run downlevel-dts script in parallel #2837
Conversation
yarn run v1.22.11 $ node ./scripts/downlevel-dts Done in 60.48s. yarn downlevel-dts 1980.35s user 87.63s system 3411% cpu 1:00.61 total
Codecov Report
@@ Coverage Diff @@
## main #2837 +/- ##
=======================================
Coverage 60.41% 60.41%
=======================================
Files 554 554
Lines 28885 28885
Branches 7072 7072
=======================================
Hits 17452 17452
Misses 11433 11433 Continue to review full report at Codecov.
|
await downlevelWorkspace(workspacesDir, workspaceName); | ||
}); | ||
|
||
parallelLimit(tasks, cpus().length, function (err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
async module is pretty awesome!
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Refs: #2834 (comment)
Description
Runs downlevel-dts scripts in parallel to improve performance.
Before
After
Testing
Verified that comments are removed from
*.d.ts
files.Tested by running manually running local
downlevel-dts
inpackages/abort-controller
followed by running globaldownlevel-dts
:Before
After
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.