Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): update clients as of 2021/12/23 #3110

merged 3 commits into from Dec 23, 2021


Copy link

@AllanZhengYP AllanZhengYP commented Dec 23, 2021


Follow up to #3078


Update clients as of 2021/12/23

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner Dec 23, 2021
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #3110 (c1980ad) into main (cac7ad0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3110   +/-   ##
  Coverage   58.72%   58.72%           
  Files         572      572           
  Lines       30632    30632           
  Branches     7541     7541           
  Hits        17990    17990           
  Misses      12642    12642           
Impacted Files Coverage Δ
...lients/client-lex-runtime-service/src/endpoints.ts 100.00% <ø> (ø)
clients/client-sts/src/endpoints.ts 100.00% <0.00%> (ø)
clients/client-s3-control/src/endpoints.ts 100.00% <0.00%> (ø)
private/aws-protocoltests-ec2/src/endpoints.ts 100.00% <0.00%> (ø)
clients/client-mediastore-data/src/endpoints.ts 100.00% <0.00%> (ø)
private/aws-protocoltests-json/src/endpoints.ts 100.00% <0.00%> (ø)
private/aws-protocoltests-query/src/endpoints.ts 100.00% <0.00%> (ø)
private/aws-protocoltests-json-10/src/endpoints.ts 100.00% <0.00%> (ø)
private/aws-protocoltests-restxml/src/endpoints.ts 100.00% <0.00%> (ø)
...rivate/aws-protocoltests-restjson/src/endpoints.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac7ad0...c1980ad. Read the comment docs.

Copy link

trivikr commented Dec 23, 2021

The unit test failure is a transient issue, and can be ignored.

Summary of all failing tests
FAIL packages/signature-v4/src/SignatureV4.spec.ts (15.778 s)
  ● SignatureV4 › ambient Date usage › should use the current date for signing if no signing date supplied

    expect(received).toBe(expected) // equality

    Expected: "20211223T202358Z"
    Received: "20211223T202357Z"

      724 |     it("should use the current date for signing if no signing date supplied", async () => {
      725 |       const { headers } = await signer.sign(minimalRequest);
    > 726 |       expect(headers[AMZ_DATE_HEADER]).toBe(iso8601(new Date()).replace(/[\-:]/g, ""));
          |                                        ^
      727 |     });
      728 |   });
      729 | });

      at src/SignatureV4.spec.ts:726:40
      at step (src/SignatureV4.spec.ts:44:23)
      at (src/SignatureV4.spec.ts:25:53)
      at fulfilled (src/SignatureV4.spec.ts:16:58)

A fix for this is attempted in #2880

Copy link
Contributor Author

AllanZhengYP commented Dec 23, 2021

Re-attempt succeeded in 9fd3720b-4387-44d7-b7ca-b5e5f222fd25

@AllanZhengYP AllanZhengYP merged commit 5d638e1 into aws:main Dec 23, 2021
5 of 6 checks passed
Copy link

github-actions bot commented Jan 7, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants