Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(clients): remove unused jest deps and config #3125

Merged
merged 7 commits into from
Jan 3, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 3, 2022

Issue

Refs: smithy-lang/smithy-typescript#483

Description

Remove unused jest dependencies and configuration

Testing

  • Verified that the jest dependency is not re-added on running yarn generate-clients
  • Verified that integration tests written in Jest are successful for client-transcribe-streaming
Output
$ pwd
/home/trivikr/workspace/aws-sdk-js-v3/clients/client-transcribe-streaming

$ yarn test:integration
yarn run v1.22.17
$ jest --config jest.integ.config.js
 PASS  test/index.integ.spec.ts (31.82 s)
  TranscribeStream client
    ✓ should stream the transcript (28874 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        32.275 s
Ran all test suites.
Done in 32.98s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore(clients): remove unused jest dependencies and configuration chore(clients): remove unused jest dependencies Jan 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #3125 (6ac70d5) into main (f851a24) will increase coverage by 16.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3125       +/-   ##
===========================================
+ Coverage   58.70%   75.18%   +16.48%     
===========================================
  Files         572      474       -98     
  Lines       30612    20721     -9891     
  Branches     7541     4755     -2786     
===========================================
- Hits        17970    15580     -2390     
+ Misses      12642     5141     -7501     
Impacted Files Coverage Δ
...mands/GetStorageLensConfigurationTaggingCommand.ts
clients/client-sts/src/runtimeConfig.shared.ts
clients/client-sts/src/defaultStsRoleAssumers.ts
...commands/PutBucketLifecycleConfigurationCommand.ts
...s3-control/src/commands/DeleteJobTaggingCommand.ts
...ts/client-lex-runtime-service/src/runtimeConfig.ts
...-control/src/commands/DeleteBucketPolicyCommand.ts
...ontrol/src/commands/PutPublicAccessBlockCommand.ts
...mands/PutStorageLensConfigurationTaggingCommand.ts
...client-s3-control/src/commands/CreateJobCommand.ts
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f851a24...6ac70d5. Read the comment docs.

@trivikr trivikr marked this pull request as ready for review January 3, 2022 16:24
@trivikr trivikr requested a review from a team as a code owner January 3, 2022 16:24
@trivikr trivikr changed the title chore(clients): remove unused jest dependencies chore(clients): remove unused jest deps and config Jan 3, 2022
@trivikr trivikr merged commit eec0a03 into aws:main Jan 3, 2022
@trivikr trivikr deleted the client-remove-jest branch January 3, 2022 23:20
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants