Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: declare jest dependencies in root package.json #3126

Merged
merged 5 commits into from
Jan 4, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 3, 2022

Issue

N/A

Description

Declares jest dependency only in root package.json

Testing

  • CI
  • Verified that test is successful in individual packages
Code
$ pwd
/local/home/trivikr/workspace/aws-sdk-js-v3/packages/abort-controller

$ ls ./node_modules/.bin
tsc  tsserver

$ yarn test
yarn run v1.22.17
$ jest
 PASS  src/AbortController.spec.ts
 PASS  src/AbortSignal.spec.ts

Test Suites: 2 passed, 2 total
Tests:       4 passed, 4 total
Snapshots:   0 total
Time:        1.139 s
Ran all test suites.
Done in 1.77s.

Additional context

This PR will be made ready after #3125 is merged.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #3126 (d133ae3) into main (eec0a03) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3126   +/-   ##
=======================================
  Coverage   75.18%   75.18%           
=======================================
  Files         474      474           
  Lines       20721    20721           
  Branches     4755     4755           
=======================================
  Hits        15580    15580           
  Misses       5141     5141           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eec0a03...d133ae3. Read the comment docs.

@trivikr trivikr marked this pull request as ready for review January 3, 2022 23:41
@trivikr trivikr requested a review from a team as a code owner January 3, 2022 23:41
@trivikr trivikr changed the title chore: declare jest dependency only in root package.json chore: declare jest dependencies in root package.json Jan 4, 2022
@trivikr trivikr merged commit b0c7cf1 into aws:main Jan 4, 2022
@trivikr trivikr deleted the remove-jest-from-packages branch January 4, 2022 14:27
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants