fix(middleware-sdk-ec2): use hostname from regionInfoProvider #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
fix/ec2-resolve-hostname
branch
from
9dd4b1a
to
4e98582
Compare
kuhe
commented
Jun 8, 2022
| @@ -81,7 +76,7 @@ export const copySnapshotPresignedUrlMiddlewareOptions: InitializeHandlerOptions | |||
| override: true, | |||
| }; | |||
|
|
|||
| export const getCopySnapshotPresignedUrlPlugin = (config: PreviouslyResolved): Pluggable<any, any> => ({ | |||
| export const getCopySnapshotPresignedUrlPlugin = (config: EC2ClientResolvedConfig): Pluggable<any, any> => ({ | |||
There was a problem hiding this comment.
https://github.com/aws/aws-sdk-js-v3/blob/main/clients/client-ec2/src/commands/CopySnapshotCommand.ts#L85 is the only caller, so this type was made more specific.
AllanZhengYP
reviewed
Jun 8, 2022
AllanZhengYP
previously approved these changes
Jun 8, 2022
AllanZhengYP
approved these changes
Jun 8, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Internal V599567416
Description
Testing