Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(credential-provider-imds): check for 'Unexpected token' of SyntaxError #4840

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 14, 2023

Issue

Fixes: #4827

Description

Just checks for string 'Unexpected token' of SyntaxError, as it's updated in Node.js 20

Testing

Verified that the test is successful in Node.js 18 and 20.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner June 14, 2023 07:24
@trivikr trivikr merged commit 9f7b466 into main Jun 14, 2023
2 checks passed
@trivikr trivikr deleted the test-credential-provider-imds-node-20 branch June 14, 2023 17:24
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[credential-provider-imds]: unit tests are failing in Node.js v20.3.0
2 participants