Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credential-provider-node): update date strings to use fully specified offsets #5790

Merged

Conversation

syall
Copy link
Contributor

@syall syall commented Feb 13, 2024

Issue

Issue number, if available, prefixed with "#"

When running yarn test:integration locally in credential-provider-node, the expiration for container-authorization would be off by a local offset.

      Object {
        "accessKeyId": "CONTAINER_ACCESS_KEY",
    -   "expiration": 3000-01-01T08:00:00.000Z,
    +   "expiration": 3000-01-01T00:00:00.000Z,
        "secretAccessKey": "CONTAINER_SECRET_ACCESS_KEY",
        "sessionToken": "CONTAINER_TOKEN",
      }

Description

What does this implement/fix? Explain your changes.

Update date strings to use fully specified offsets.

Testing

How was this change tested?

  1. yarn test:integration
  2. CI passes

Additional context

Add any other context about the PR here.

N/A.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@syall syall marked this pull request as ready for review February 13, 2024 18:37
@syall syall requested a review from a team as a code owner February 13, 2024 18:37
@syall syall force-pushed the fix-credential-chain-integ-test-container-expiration branch from 24600ba to 0ee11af Compare February 13, 2024 19:03
@syall syall changed the title fix(credential-provider-node): update container-authorization expiration to use Date fix(credential-provider-node): update date strings to use fully specified offsets Feb 13, 2024
@syall syall force-pushed the fix-credential-chain-integ-test-container-expiration branch from 0ee11af to 67a0dda Compare February 13, 2024 19:07
@syall syall merged commit 0bc9f48 into aws:main Feb 13, 2024
3 checks passed
@syall syall deleted the fix-credential-chain-integ-test-container-expiration branch February 13, 2024 20:13
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants