fix(middleware-signing): attempt secondary authscheme selection during request signing #5895
Conversation
…g request signing
| // user supplied signingName -> endpoints.json inferred (credential scope -> model arnNamespace) -> model service id | ||
| input.signingName = input.signingName || signingService || input.serviceId; | ||
|
|
||
| if (overwrite) { |
There was a problem hiding this comment.
nit: overwrite reads like the input.* parameters would be overwritten, but the code path here is using the original input.* parameters.
There was a problem hiding this comment.
unfortunately this part of the code mutates the config during signing and not during the constructor config resolution
There was a problem hiding this comment.
I changed it to only mutate if authscheme is not sigv4a. Sigv4a doesn't contain a meaningful region so far, so we can skip writing that to the input and leave it to any further resolutions containing a singular region.
Co-authored-by: Steven Yuan <s.yuan.all@gmail.com>
…authscheme is sigv4a
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
S3 feature release
2ddd8ec
Description
In awsAuthMiddleware, select the second authScheme if:
Testing
existing unit test