Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: codegen with payload serialization #725

Merged
merged 1 commit into from Jan 13, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 13, 2020

Issue #, if available:
Refs: smithy-lang/smithy-typescript#90

Description of changes:
codegen with payload serialization

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future reference: In S3, they model 200 as success code but actually return 204, but in fact we shouldn't treat as excetption. This change fixes the problem.

@trivikr trivikr merged commit a02317c into aws:smithy-codegen Jan 13, 2020
@trivikr trivikr deleted the payload-serialization branch January 13, 2020 21:53
@lock
Copy link

lock bot commented Jan 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants