Allow payload serialization to be overridden #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for implementing protocols to override the serialization behavior of a member marked with @httpPayload. This is useful for protocols that work with intermediate objects that need to be altered at the service level. Adding a top level xmlns attribute, for example. This commit also fixes various bugs found in testing behavior developed on top of the main change.
mtdowling
reviewed
Jan 12, 2020
| * <p>For example: | ||
| * | ||
| * <pre>{@code | ||
| * if (input.body !== undefined) { |
|
The only other clear way to handle the scope that this change allows would be to add a single protected method to allow for arbitrarily manipulating the value currently being set in to Its purpose would be a little less clear, but there's potentially less chance for a downstream consumer to miss-handle processing of Payloads. |
|
Ok. I'm still not thrilled about the API surface area, but LGTM for now. |
mtdowling
approved these changes
Jan 13, 2020
trivikr
added a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Jan 13, 2020
trivikr
added a commit
to aws/aws-sdk-js-v3
that referenced
this pull request
Jan 13, 2020
AllanZhengYP
pushed a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
trivikr
added a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
trivikr
added a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
trivikr
added a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for implementing protocols to override the
serialization behavior of a member marked with @httpPayload. This is
useful for protocols that work with intermediate objects that need to
be altered at the service level. Adding a top level xmlns attribute,
for example.
This commit also fixes various bugs found in testing behavior developed
on top of the main change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.