Skip to content

Commit

Permalink
Allow use of locationName on non-flattened lists
Browse files Browse the repository at this point in the history
  • Loading branch information
jeskew committed Feb 15, 2017
1 parent e4d72fc commit db1e264
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 17 deletions.
2 changes: 1 addition & 1 deletion lib/query/query_param_serializer.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function serializeList(name, list, rules, fn) {
name = parts.join('.');
}
} else {
suffix = '.member' + suffix;
suffix = '.' + (memberRules.name ? memberRules.name : 'member') + suffix;
}
serializeMember(name + suffix, v, memberRules, fn);
});
Expand Down
19 changes: 3 additions & 16 deletions test/query/query_param_serializer.spec.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -190,19 +190,6 @@ describe 'QueryParamSerializer', ->
['Person.member.3', 'c'],
])

it 'ignores the list-member name', ->
rules =
Person:
type: 'list'
member:
locationName: 'Name'
params = serialize({Person:['a','b','c']}, rules)
expect(params).to.eql([
['Person.member.1', 'a'],
['Person.member.2', 'b'],
['Person.member.3', 'c'],
])

it 'observes both list name and list member name', ->
rules =
People:
Expand All @@ -212,9 +199,9 @@ describe 'QueryParamSerializer', ->
locationName: 'Name'
params = serialize({People:['a','b','c']}, rules)
expect(params).to.eql([
['Person.member.1', 'a'],
['Person.member.2', 'b'],
['Person.member.3', 'c'],
['Person.Name.1', 'a'],
['Person.Name.2', 'b'],
['Person.Name.3', 'c'],
])

describe 'maps', -> # maps are hashes with user defined keys
Expand Down

0 comments on commit db1e264

Please sign in to comment.