Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync latest version of protocol tests #1407

Merged
merged 3 commits into from
Mar 17, 2017

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Mar 16, 2017

This PR also adds support for a recent addition to the protocol (jsonvalue flags on headers).

/cc @chrisradek

@codecov-io
Copy link

codecov-io commented Mar 16, 2017

Codecov Report

Merging #1407 into master will increase coverage by 4.32%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
+ Coverage   90.85%   95.18%   +4.32%     
==========================================
  Files         173      174       +1     
  Lines        6113     6124      +11     
  Branches     1249     1250       +1     
==========================================
+ Hits         5554     5829     +275     
+ Misses        559      295     -264
Impacted Files Coverage Δ
lib/param_validator.js 97.1% <100%> (+0.06%)
lib/protocol/rest.js 100% <100%> (ø)
lib/model/shape.js 94.3% <100%> (+0.05%)
index.js 100% <0%> (ø)
lib/services/iotdata.js 30.76% <0%> (+15.38%)
clients/cloudsearch.js 76.47% <0%> (+23.52%)
clients/lambda.js 76.47% <0%> (+23.52%)
clients/iotdata.js 100% <0%> (+25%)
clients/pinpoint.js 100% <0%> (+27.27%)
clients/servicecatalog.js 100% <0%> (+27.27%)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2016fa...b465137. Read the comment docs.

Copy link
Contributor

@chrisradek chrisradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeskew jeskew merged commit e516ed8 into aws:master Mar 17, 2017
@jeskew jeskew deleted the chore/sync-protocol-tests branch March 29, 2017 22:55
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants