Remove coffeescript #3432
Remove coffeescript #3432
Conversation
These headers give the impression that they should not be modified and the "source" file should be instead – but given there are no source *.coffee files (anymore), this is misleading. They also prevent tools (like GitHub) from displaying diffs in these files by default because they rightly assume the files were generated
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue. |
github-actions
bot
added
the
closing-soon
|
Yup, still an issue afaict |
trivikr
removed
the
closing-soon
|
Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue. |
github-actions
bot
added
closing-soon
It seems it's only needed for a couple of files that can be converted into JS.
It's also misleading to have all the "Generated by CoffeeScript" comments in JS files now that the corresponding *.coffee files no longer exist – it implies they aren't the source of truth (they are now) and it also misleads tools like GitHub into thinking the files are still generated and so it doesn't display diffs for them by default.
Checklist
npm run testpassesnpm run add-change