-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #2171: Honor 'use_aws_shared_config_files' for process… #2172
Merged
Commits on Dec 14, 2020
-
Resolves #2171: Honor 'use_aws_shared_config_files' for the process-b…
…ased CredentialProvider For the credential resolver whereby the default ~/.aws/config and ~/.aws/credentials are evaluated for access credentials, the config variable 'use_aws_shared_config_files' is considered. However, for the process-based credential resolver, checking the same $HOME directory shared config files, it is not. This adds the same conditional check to ensure those files are not considered for either method where configuration is explicitly supplied indicating they should not be.
Configuration menu - View commit details
-
Copy full SHA for 0374cb8 - Browse repository at this point
Copy the full SHA 0374cb8View commit details
Commits on Dec 15, 2020
-
Group profile config file types
The default ordering is supposed to be: 1) env 2) web identity 3) profile config 4) Container/Instance The process type is a relative new add. However, it was put below ECS. In the Java SDK, all profile processing (and case logic) is together in the search order. This makes that match. See Also: https://github.com/aws/aws-sdk-java/blob/1.11.918/aws-java-sdk-core/src/main/java/com/amazonaws/auth/profile/ProfilesConfigFile.java#L207-L216
Configuration menu - View commit details
-
Copy full SHA for 66c15f1 - Browse repository at this point
Copy the full SHA 66c15f1View commit details -
Only ECS or instance profile valid, not both
The default ordering is supposed to be: 1) env 2) web identity 3) profile config 4) Container/Instance ECS deployments and instance profiles are easily detectable via an environment variable. If the environment variable is present, add the ECS provider to the chain; otherwise, add the instance profile provider. See Also: https://github.com/aws/aws-sdk-java/blob/1.11.918/aws-java-sdk-core/src/main/java/com/amazonaws/auth/EC2ContainerCredentialsProviderWrapper.java#L58-L64
Configuration menu - View commit details
-
Copy full SHA for 76393f4 - Browse repository at this point
Copy the full SHA 76393f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49a3da2 - Browse repository at this point
Copy the full SHA 49a3da2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5699a89 - Browse repository at this point
Copy the full SHA 5699a89View commit details
Commits on Dec 16, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 67cc9c6 - Browse repository at this point
Copy the full SHA 67cc9c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ec8b6ab - Browse repository at this point
Copy the full SHA ec8b6abView commit details
Commits on Dec 17, 2020
-
Aligning terminology on role and SSO
Comment stanza to match up with the terminology used throughout the code.
Configuration menu - View commit details
-
Copy full SHA for d9b2fdb - Browse repository at this point
Copy the full SHA d9b2fdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a17a5d - Browse repository at this point
Copy the full SHA 3a17a5dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.