Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #2171: Honor 'use_aws_shared_config_files' for process… #2172

Merged
merged 9 commits into from
Dec 17, 2020
Merged

Resolves #2171: Honor 'use_aws_shared_config_files' for process… #2172

merged 9 commits into from
Dec 17, 2020

Commits on Dec 14, 2020

  1. Resolves #2171: Honor 'use_aws_shared_config_files' for the process-b…

    …ased CredentialProvider
    
    For the credential resolver whereby the default ~/.aws/config and ~/.aws/credentials are evaluated for access credentials, the config variable 'use_aws_shared_config_files' is considered. However, for the process-based credential resolver, checking the same $HOME directory shared config files, it is not. This adds the same conditional check to ensure those files are not considered for either method where configuration is explicitly supplied indicating they should not be.
    cuppett committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    0374cb8 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Group profile config file types

    The default ordering is supposed to be:
    1) env
    2) web identity
    3) profile config
    4) Container/Instance
    
    The process type is a relative new add. However, it was put below ECS. In the Java SDK, all profile processing (and case logic) is together in the search order. This makes that match.
    
    See Also: https://github.com/aws/aws-sdk-java/blob/1.11.918/aws-java-sdk-core/src/main/java/com/amazonaws/auth/profile/ProfilesConfigFile.java#L207-L216
    cuppett committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    66c15f1 View commit details
    Browse the repository at this point in the history
  2. Only ECS or instance profile valid, not both

    The default ordering is supposed to be:
    1) env
    2) web identity
    3) profile config
    4) Container/Instance
    
    ECS deployments and instance profiles are easily detectable via an environment variable. If the environment variable is present, add the ECS provider to the chain; otherwise, add the instance profile provider.
    
    See Also: https://github.com/aws/aws-sdk-java/blob/1.11.918/aws-java-sdk-core/src/main/java/com/amazonaws/auth/EC2ContainerCredentialsProviderWrapper.java#L58-L64
    cuppett committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    76393f4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    49a3da2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5699a89 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Configuration menu
    Copy the full SHA
    67cc9c6 View commit details
    Browse the repository at this point in the history
  2. Adding changelog

    cuppett committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    ec8b6ab View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Aligning terminology on role and SSO

    Comment stanza to match up with the terminology used throughout the code.
    cuppett committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    d9b2fdb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a17a5d View commit details
    Browse the repository at this point in the history