Add a manifest for AWS Config Service #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,8 +4,8 @@ build/artifacts | |||
| phpunit.xml | |||
| phpunit.functional.xml | |||
| test_services.json | |||
| Config | |||
| ./Makefile | |||
| /Config | |||
There was a problem hiding this comment.
This line was meant to exclude a file at the project root named Config but was also excluding a folder from the AWS manifests for a service named config.
|
Awesome. You're official now. 🚢 |
| @@ -25,4 +25,4 @@ install: | |||
|
|
|||
| script: | |||
| - make test | |||
| - [ -z "$COMPOSER_OPTS" ] && make package | |||
There was a problem hiding this comment.
Why this change? Was it not working before?
There was a problem hiding this comment.
Travis was failing to interpret the manifest file and wasn't testing any new builds.
jeskew
added a commit
that referenced
this pull request
Jun 15, 2015
Add a manifest for AWS Config Service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.