Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amazonq): Update cross file context config #4922

Merged
merged 2 commits into from
May 3, 2024
Merged

fix(amazonq): Update cross file context config #4922

merged 2 commits into from
May 3, 2024

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented May 2, 2024 •
edited

Problem

  1. number of input chunks for BM25 retrieval needs to be changed from 60 to 200,
  2. the chunk size is changed from 10 lines to 50 lines, which means totally 200x 50 lines of cross-file code will be considered in the BM25 retrieval.
  3. number of chunks returned from plugin to server for prompting increased from 3 to 10.

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested review from a team as code owners May 2, 2024 23:05
@leigaol leigaol marked this pull request as draft May 2, 2024 23:27
@leigaol leigaol marked this pull request as ready for review May 2, 2024 23:53
@justinmk3 justinmk3 merged commit e6d9b50 into aws:master May 3, 2024
12 of 14 checks passed
hayemaxi added a commit that referenced this pull request May 8, 2024
@hayemaxi
Revert "fix(amazonq): update cross file context config #4922"
117b30a 
This reverts commit e6d9b50.
leigaol added a commit to leigaol/aws-toolkit-vscode that referenced this pull request May 8, 2024
@leigaol
Revert "fix(amazonq): update cross file context config aws#4922"
658c6dd 
This reverts commit e6d9b50.
@leigaol leigaol mentioned this pull request May 8, 2024
Merged
hayemaxi pushed a commit that referenced this pull request May 8, 2024
@leigaol
Revert "fix(amazonq): update cross file context config" (#4961)
8bd66cc 
* Revert "fix(amazonq): update cross file context config #4922"

This reverts commit e6d9b50.

* revert cross file config change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leigaol @justinmk3