fix(amazonq): incorrect project scan size limit #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laileni-aws
approved these changes
May 3, 2024
andrewyuq
approved these changes
May 3, 2024
jpinkney-aws
requested changes
May 3, 2024
| @@ -69,7 +69,8 @@ async function filterOutGitignoredFiles(rootPath: string, files: Uri[]): Promise | |||
| export async function collectFiles( | |||
| sourcePaths: string[], | |||
| workspaceFolders: CurrentWsFolders, | |||
| respectGitIgnore: boolean = true | |||
| respectGitIgnore: boolean = true, | |||
| maxSize = maxRepoSizeBytes | |||
There was a problem hiding this comment.
I think we have an opportunity to improve some quality in the codebase which was probably left over from re-invent. It looks like codewhisperer is importing from the featureDev part of the codebase. If this is the case, can we pull collectFiles out to a different place?
Generic utils (like collectFiles) used by multiple q products shouldn't be in individual products part of the codebase.
Also, was this issue caused by a lack of tests? Because we should be adding more tests to know that this issue is fixed
justinmk3
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
collectFilesmethod uses a different max payload size value than security scans.Solution
collectFilesLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.