Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amazonq): update icons for Auth on Login Page #4932

Merged
merged 1 commit into from
May 9, 2024
Merged

fix(amazonq): update icons for Auth on Login Page #4932

merged 1 commit into from
May 9, 2024

Conversation

ivikash
Copy link
Member

@ivikash ivikash commented May 5, 2024 •
edited

Problem

Icons are not displayed on for existing connections.

Solution

  • Use type to render icons
Screenshot 2024-05-06 at 6 53 22 PM

Notes

  • Discuss a better way to differentiate between SSO and IAM Login in Frontend.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ivikash ivikash requested a review from a team as a code owner May 5, 2024 17:51
@ivikash ivikash marked this pull request as draft May 6, 2024 06:35
@ivikash
Copy link
Member Author

ivikash commented May 7, 2024 •
edited

/runIntegrationTests

@ivikash ivikash marked this pull request as ready for review May 7, 2024 02:00
@ivikash ivikash requested a review from justinmk3 May 7, 2024 02:00
@justinmk3 justinmk3 merged commit 5d19062 into aws:master May 9, 2024
20 checks passed
@ivikash ivikash deleted the fix/login-icons branch May 9, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk3 justinmk3 Awaiting requested review from justinmk3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivikash @justinmk3