Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(login): add help link #4940

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

ivikash
Copy link
Member

@ivikash ivikash commented May 7, 2024

Problem

Add Help link in Login Page.

Solution

  • Introducing BEM naming convention for classes/CSS - https://getbem.com/.
  • Use ? for icon.
  • Record Telemetry data when a user clicks the help link.
Screenshot 2024-05-07 at 12 01 29 AM

TODO

  • UX Review

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ivikash ivikash requested a review from a team as a code owner May 7, 2024 07:06
@jparkhurst3
Copy link

LGTM

@ivikash
Copy link
Member Author

ivikash commented May 7, 2024

Dark Theme Light Theme
Screenshot 2024-05-07 at 11 09 40 AM Screenshot 2024-05-07 at 11 10 02 AM

@ivikash
Copy link
Member Author

ivikash commented May 7, 2024

Screenshot 2024-05-07 at 11 37 28 AM

2024-05-07 11:36:51.226 [debug] Webview called command "storeMetricMetadata" with args: [ { region: 'us-east-1' } ]
2024-05-07 11:36:54.203 [debug] Webview called command "emitUiClick" with args: [ 'auth_helpLink' ]
2024-05-07 11:36:54.203 [debug] telemetry: ui_click {
  Metadata: {
    elementId: 'auth_helpLink',
    awsAccount: 'not-set',
    awsRegion: 'us-east-1'
  },
  Value: 1,
  Unit: 'None',
  Passive: false
}

@justinmk3 justinmk3 merged commit c362f13 into aws:master May 7, 2024
14 checks passed
@ivikash ivikash deleted the feat/login-sso-help-link branch May 7, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants