Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a conversationId as an info log to ease customer feedback #4942

Merged
merged 1 commit into from
May 7, 2024

Conversation

sannicm
Copy link
Contributor

@sannicm sannicm commented May 7, 2024

Problem

Searching for the conversationId in logs could be cumbersome for some customers. This aims to make it a little bit easier.

Solution

Add an info level log with the conversation id in approach and code generation, including their iterations for easy conversation Id finding.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jsalles
Copy link
Contributor

jsalles commented May 7, 2024

Can we also add this log message after we receive the conversationId from StartConversation?
That way we'll have this info for flows that fail before starting planning.

@sannicm
Copy link
Contributor Author

sannicm commented May 7, 2024

Can we also add this log message after we receive the conversationId from StartConversation? That way we'll have this info for flows that fail before starting planning

Printing effectively after the preloader runs is doing what you suggest, printing before any approach interaction is done. This way we would have conversationId in every approach plan or plan iteration as well before any upload or generation.

@nkomonen-amazon nkomonen-amazon merged commit 617952d into aws:master May 7, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants