Fix bug where messages to chat got lost. #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
approved these changes
May 7, 2024
dhasani23
approved these changes
May 7, 2024
damntrecky
reviewed
May 7, 2024
| break | ||
| case ButtonActions.VIEW_TRANSFORMATION_HUB: | ||
| await vscode.commands.executeCommand(GumbyCommands.FOCUS_TRANSFORMATION_HUB) | ||
| this.messenger.sendJobSubmittedMessage(message.tabId) | ||
| this.messenger.sendJobSubmittedMessage(message.tabID) |
There was a problem hiding this comment.
Question: I thought we were keeping tabId and removing tabID? @JuliaABurch
There was a problem hiding this comment.
It would mean much more changes and in addition it seems tabID is more common anyhow:
tabId occurences: 84 in 12 files
tabID occurences: 891 in 43 files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Messages get lost in the code path where customers do not need to provide a JAVA_HOME.
This leads to missing chat bubbles for
Solution
Issue was due to typo when translating
tabIdtotabID.Search in the code shows that
tabIDis 10x more common thantabIdso aligning Q Code Transform to this format.After aligning the usages the missing messages are shown again and are animated where required.
Before fix
I'm building your project ...text does not showAfter fix
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.