docs: guidance for UX related PRs #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
May 7, 2024
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -12,6 +12,20 @@ | |||
| - Screenshots | |||
There was a problem hiding this comment.
Screenshots are already mentioned here. Adding more text is unlikely to be read by contributors, we want to keep the instructions as minimal and relevant as possible.
Is dark/light theme a common enough topic that it needs to be a permanent part of the PR template?
ivikash
force-pushed
the
chore/update-pr-template
branch
from
22d2473
to
7e70539
Compare
ivikash
force-pushed
the
chore/update-pr-template
branch
from
7e70539
to
8497ff0
Compare
justinmk3
reviewed
May 7, 2024
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -9,7 +9,8 @@ | |||
| - Update the changelog using `npm run newChange`. | |||
| - Link to related issues/commits. | |||
| - Testing: how did you test your changes? | |||
| - Screenshots | |||
| - Screenshots (if the pull request is related to UI/UX then please include light and dark theme screenshots) | |||
| - UX Reviews and Sign-off | |||
There was a problem hiding this comment.
UX review/signoff is more of a project-level requirement which would be tracked in our project system.
justinmk3
reviewed
May 7, 2024
justinmk3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PR template to include guidance for UI/UX related PRs
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.